Refactoring Unit-Tests

Transkript

1 def = '' [email protected] assert_equal ["is invalid", "can't = 'dhjxfgjdxfj' [email protected] assert_equal = 'dhjx@fgjdxfj' [email protected] assert_equal = '[email protected]' [email protected] assert_equal = = '[email protected]' Refactoring Unit-Tests Dipl.-Inf. (FH) Marco Emrich Nov 2013 #XDDE13

2 Realer Code webmasters.de 2005

3 def = = '' [email protected] assert_equal ["is too short (minimum is 5 characters)", "has invalid characters", "can't = = 'testtest' [email protected] assert_equal "doesn't = = 'testtest' [email protected] assert_equal ["is too short (minimum is 5 characters)", "has invalid characters", "doesn't match confirmation", "can't = = '' [email protected] assert_equal "doesn't = = 'test' [email protected] assert_equal "is too short (minimum is = = 'testet'

4 def = = '' [email protected] assert_equal ["is too short (minimum is 5 characters)", "has invalid characters", "can't = = 'testtest' [email protected] assert_equal "doesn't = = 'testtest' [email protected] assert_equal ["is too short (minimum is 5 characters)", "has invalid characters", "doesn't match confirmation", "can't be = = '' [email protected] assert_equal "doesn't = = 'test' [email protected] assert_equal "is too short (minimum is = = 'testet'

5 Es gibt noch Hoffnung

6 Test Refactoring

7 Beispiel

8 Seminar-Shop

9 Seminar-Shop

10

11 Specs Seminare haben Name und Nettopreis Ruby Java

12 Specs Seminare haben Name und Nettopreis Seminare berechnen Ihren Bruttopreis - außer, sie sind steuerbefreit Ruby Java

13 Marketing-Abteilung

14 3-Buchstaben Rabatt

15 Specs Seminare haben Name und Nettopreis Seminare berechnen Ihren Bruttopreis - außer, sie sind steuerbefreit 3-Buchstaben-Seminare* bekommen 5% Rabatt Ruby Java

16 class Seminar TAX_RATE = 1.19 THREE_LETTER_DISCOUNT_RATE = 5 attr_writer :net_price, :tax_free, :name def discount_rate discount_granted?? THREE_LETTER_DISCOUNT_RATE : 0 def initialize(name, @tax_free = name, net_price, tax_free def gross_price net_price * tax_rate def - discount def 1 : TAX_RATE / 100 def * discount_rate / 100 def < 3

17 class Seminar TAX_RATE = 1.19 THREE_LETTER_DISCOUNT_RATE = 5 attr_writer :net_price, :tax_free, :name def discount_rate discount_granted?? THREE_LETTER_DISCOUNT_RATE : 0 def initialize(name, @tax_free = name, net_price, tax_free def gross_price net_price * tax_rate def - discount def 1 : TAX_RATE / 100 def * discount_rate / 100 def < 3

18 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.net_price = 300 assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 285, seminar.gross_price seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 300, seminar.gross_price

19 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.net_price = 300 assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 285, seminar.gross_price Failure: <565.25> expected but was <5.95>. seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 300, seminar.gross_price

20 3 Minuten

21 Fehler gefunden?

22 2 Fehler gefunden?

23 3 Fehler gefunden?

24 Alternative Test-Suite: 9 Testfälle

25 def test_seminar_should_have_the_german_mwst_tax_rate_if_it_is_not_tax_free seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate Failure: <1.19> expected but was <0.0119>. def test_discount_granted_should_return_true_if_name_consists_of_3_letters seminar = create_seminar(name: 'OOP') # 3 Buchstaben assert seminar.discount_granted? Failure: <false> is not true.

26 3 Minuten

27 Fehler gefunden?

28 2 Fehler gefunden?

29 3 Fehler gefunden?

30 class Seminar TAX_RATE = 1.19 THREE_LETTER_DISCOUNT_RATE = 5 attr_writer :net_price, :tax_free, :name def discount_rate discount_granted?? THREE_LETTER_DISCOUNT_RATE : 0 def initialize(name, @tax_free = name, net_price, tax_free def gross_price net_price * tax_rate def - discount def 1 : TAX_RATE / 100 def * discount_rate / 100 def < 3

31 class Seminar TAX_RATE = 1.19 THREE_LETTER_DISCOUNT_RATE = 5 attr_writer :net_price, :tax_free, :name def discount_rate discount_granted?? THREE_LETTER_DISCOUNT_RATE : 0 def initialize(name, @tax_free = name, net_price, tax_free def gross_price net_price * tax_rate def - discount def 1 : TAX_RATE def * discount_rate / 100 def <= 3

32 Vergleich der Testsuites

33 Qualitätskriterien für Testfälle

34 Qualitätskriterien guter Testfälle hohe Lesbarkeit, leicht zu verstehen Tests sind schwierig zu testen als Dokumentation der Anforderungen verwbar => BDD: Specs

35 Qualitätskriterien guter Testfälle hohe Lesbarkeit, leicht zu verstehen hohe Ausführungsgeschwindigkeit Häufige Ausführung

36 Qualitätskriterien guter Testfälle hohe Lesbarkeit, leicht zu verstehen hohe Ausführungsgeschwindigkeit geringer Wartungsaufwand möglichst Redundanzfrei: DRY geringer Test-Overlap geringe Kopplung an den Produktivcode

37 Qualitätskriterien guter Testfälle hohe Lesbarkeit, leicht zu verstehen hohe Ausführungsgeschwindigkeit geringer Wartungsaufwand gute Defekt-Lokalisierung Rainsberger: Jede Testmethode prüft genau eine interessantes Verhaltensweise

38 Qualitätskriterien guter Testfälle Lesbar Schnell Wartbar gute Defekt-Lokalisierung

39 Qualitätskriterien guter Testfälle manchmal Widersprüchliche Anforderungen

40 Qualitätskriterien guter Testfälle Optimaler Kompromiss?

41 Kent Beck TDD

42 BDD Meet BDD (Dan North oder King Image) Dan North

43 TDD/BDD führen zu guten Tests!

44 TDD/BDD führen zu guten Tests! (nicht unbedingt automatisch)

45 Verbesserungen möglich!

46 Legacy Test Suites

47 Testcode muss gewartet werden

48 Test Refactoring

49 Beispiel

50 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.net_price = 300 assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 285, seminar.gross_price seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 300, seminar.gross_price

51 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.net_price = 300 assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 285, seminar.gross_price seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 300, seminar.gross_price Remove Redudant Tests (gleiche Äquivalenzklasse)

52 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.net_price = 300 assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 475, seminar.gross_price seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 500, seminar.gross_price Remove Redudant Tests

53 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('OOP', 500, false) assert_equal , seminar.gross_price seminar.tax_free = true assert_equal 475, seminar.gross_price seminar.name = 'Objekt-Orientierte Programmierung' assert_equal 500, seminar.gross_price

54 class SeminarTest < Test::Unit::TestCase def test_seminar_should_calculate_correct_gross_prices seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, true) assert_equal 500, seminar.gross_price seminar.name = 'OOP' assert_equal 475, seminar.gross_price seminar.tax_free = false assert_equal , seminar.gross_price Use neutral fixture (Build up!)

55 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, true) assert_equal 500, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, false) assert_equal 595, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = Seminar.new('OOP', 500, true) assert_equal 475, seminar.gross_price Split test methods Fresh fixture Arrange Act Assert: AAA-Pattern

56 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, true) assert_equal 500, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, false) assert_equal 595, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = Seminar.new('OOP', 500, true) assert_equal 475, seminar.gross_price Use test data factories

57 Test data factories Ruby-Frameworks Factory-Girl Machinist Java-Frameworks Patterns Usurper PojoBuilder Object Mothers Test Data Builders Example Factories

58 class SeminarTest < Test::Unit::TestCase def create_seminar(args = {}) new_args = { :name => 'Object Oriented Programming', :net_price => 500, :tax_free => true }.merge(args) Defaults (neutral Fixture) Seminar.new(new_args[:name], new_args[:net_price], new_args[:tax_free]) Use factories

59 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, true) seminar = create_seminar(tax_free: true) assert_equal 500, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = Seminar.new('Objekt-Orientierte Programmierung', 500, false) seminar = create_seminar(tax_free: false) assert_equal 595, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = Seminar.new('OOP', 500, true) seminar = create_seminar(name: 'OOP') assert_equal 475, seminar.gross_price Use factories

60 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = create_seminar(tax_free: true) assert_equal 500, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = create_seminar(tax_free: false) assert_equal 595, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP') assert_equal 475, seminar.gross_price Use factories

61 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = create_seminar(tax_free: true) assert_equal seminar.net_price, seminar.gross_price 500 def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = create_seminar(tax_free: false) assert_equal seminar.net_price * Seminar::TAX_RATE, seminar.gross_price 500 def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP', net_price: 500) assert_equal 500 * 0.95, seminar.gross_price Use factories

62 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = create_seminar(tax_free: true) assert_equal seminar.net_price, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = create_seminar(tax_free: false) assert_equal seminar.net_price * Seminar::TAX_RATE, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP', net_price: 500) assert_equal 500 * 0.95, seminar.gross_price add missing test

63 class SeminarTest < Test::Unit::TestCase def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = create_seminar(tax_free: true) assert_equal seminar.net_price, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = create_seminar(tax_free: false) assert_equal seminar.net_price * Seminar::TAX_RATE, seminar.gross_price def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP', net_price: 500) assert_equal 500 * 0.95, seminar.gross_price def test_a_more_letters_seminar_should_return_a_net_price_without_discount seminar = create_seminar(name: 'Object O. Programming', net_price: 500) assert_equal 500, seminar.gross_price add missing test

64 Discount def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP') assert_equal 500 * 0.95, seminar.gross_price def test_a_more_letters_seminar_should_return_a_net_price_without_discount seminar = create_seminar(name: 'Object Oriented Programming') assert_equal 500, seminar.gross_price class Seminar def gross_price net_price * tax_rate def - discount Isolate def * discount_rate / 100

65 Discount def test_a_3letter_seminar_should_return_a_gross_price_with_discount seminar = create_seminar(name: 'OOP') assert_equal 500 * 0.95, seminar.net_price.gross_price def test_a_more_letters_seminar_should_return_a_net_price_without_discount seminar = create_seminar(name: 'Object Oriented Programming') assert_equal 500, seminar.net_price.gross_price class Seminar def gross_price net_price * tax_rate def - discount Isolate def * discount_rate / 100

66 Tax def test_a_tax_free_seminar_should_return_a_gross_price_without_tax seminar = create_seminar(tax_free: true) assert_equal seminar.net_price, seminar.gross_price def test_a_not_tax_free_seminar_should_return_gross_price_with_correct_tax seminar = create_seminar(tax_free: false) assert_equal seminar.net_price * Seminar::TAX_RATE, seminar.gross_price class Seminar def gross_price net_price * tax_rate Isolate def 1 : TAX_RATE / 100

67 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal seminar.net_price, seminar.gross_price assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal seminar.net_price * Seminar::TAX_RATE, seminar.gross_price assert_equal Seminar::TAX_RATE, seminar.tax_rate class Seminar def gross_price net_price * tax_rate Isolate def 1 : TAX_RATE / 100

68 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate class Seminar def gross_price net_price * tax_rate Isolate def 1 : TAX_RATE / 100

69 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate class Seminar def gross_price net_price * tax_rate Lost Coverage def 1 : TAX_RATE / 100

70 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate def test_seminar_should_use_tax_rate_to_calculate_gross_price class Seminar def gross_price net_price * tax_rate Lost Coverage def 1 : TAX_RATE / 100 def - discount

71 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate def test_seminar_should_use_tax_rate_to_calculate_gross_price seminar = create_seminar(tax_free: false) assert_equal?, seminar.gross_price Isolate Use Stubs class Seminar def gross_price net_price * tax_rate def 1 : TAX_RATE / 100 def - discount

72 Tax def test_a_tax_free_seminar_should_have_a_tax_rate_of_1 seminar = create_seminar(tax_free: true) assert_equal 1, seminar.tax_rate def test_a_not_tax_free_seminar_should_have_the_correct_tax_rate seminar = create_seminar(tax_free: false) assert_equal Seminar::TAX_RATE, seminar.tax_rate def test_seminar_should_use_tax_rate_to_calculate_gross_price seminar = create_seminar(tax_free: false) seminar.stubs(net_price: 100) seminar.stubs(tax_rate: 1.5) assert_equal 150, seminar.gross_price class Seminar def gross_price net_price * tax_rate Isolate Use Stubs def 1 : TAX_RATE / 100 def - discount

73 Mocks & Stubs Ruby Rspec-Mocks Mocha FlexMock Java EasyMock Mockito Jmockit JavaScript SinonJS Jasmine Spies

74 BDD-Frameworks Ruby RSpec Shoulda Java JDave Jnario ScalaTest JavaScript Jasmine Mocha more readable!

75

76 Github: XING:

77 Hands-On 1)Paare bilden 2)Sprache wählen: Ruby, Java oder JavaScript 3)Code auschecken git clone 4)Loslegen :)